Skip to content

chore: Nest skill and protocol network permissions under network.enabled#13427

Merged
celia-oai merged 1 commit intomainfrom
dev/cc/rebase
Mar 4, 2026
Merged

chore: Nest skill and protocol network permissions under network.enabled#13427
celia-oai merged 1 commit intomainfrom
dev/cc/rebase

Conversation

@celia-oai
Copy link
Collaborator

@celia-oai celia-oai commented Mar 4, 2026

Summary

Changes the permission profile shape from a bare network boolean to a nested object.

Before:

permissions:
  network: true

After:

permissions:
  network:
    enabled: true

This also updates the shared Rust and app-server protocol types so PermissionProfile.network is no longer Option<bool>, but Option<NetworkPermissions> with enabled: Option<bool>.

What Changed

  • Updated PermissionProfile in codex-rs/protocol/src/models.rs:
    • pub network: Option<bool> -> pub network: Option<NetworkPermissions>
  • Added NetworkPermissions with:
    • pub enabled: Option<bool>
  • Changed emptiness semantics so network is only considered empty when enabled is None
  • Updated skill metadata parsing to accept permissions.network.enabled
  • Updated core permission consumers to read network.enabled.unwrap_or(false) where a concrete boolean is needed
  • Updated app-server v2 protocol types and regenerated schema/TypeScript outputs
  • Updated docs to mention additionalPermissions.network.enabled

@celia-oai celia-oai changed the title changes chore: Nest skill and protocol network permissions under \network.enabled\ Mar 4, 2026
@celia-oai celia-oai changed the title chore: Nest skill and protocol network permissions under \network.enabled\ chore: Nest skill and protocol network permissions under network.enabled Mar 4, 2026
@celia-oai celia-oai marked this pull request as ready for review March 4, 2026 04:47
@celia-oai celia-oai merged commit d622bff into main Mar 4, 2026
31 checks passed
@celia-oai celia-oai deleted the dev/cc/rebase branch March 4, 2026 04:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants