Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcfeb15f7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let mut output = File::create(&output_path).map_err(|source| PackageManagerError::Io { | ||
| context: format!("failed to create {}", output_path.display()), | ||
| source, | ||
| })?; | ||
| std::io::copy(&mut entry, &mut output).map_err(|source| PackageManagerError::Io { | ||
| context: format!("failed to write {}", output_path.display()), |
There was a problem hiding this comment.
extract_zip_archive writes files with File::create + copy but never reapplies ZIP entry mode bits. Executables in the runtime archive (notably node/bin/node) will be installed as non-executable on Unix, causing later execute_build/execute_render spawns to fail with permission errors. Read entry mode metadata and set file permissions after extraction.
Useful? React with 👍 / 👎.
1 participant
This PR reverts the built-in artifact render while a decision is being reached. No impact expected on any features