Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b98079fc1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| *items = original_items | ||
| .into_iter() | ||
| .map(|item| match item { | ||
| ResponseItem::ImageGenerationCall { result, .. } => { |
There was a problem hiding this comment.
Rewrite only completed image generations into input images
rewrite_image_generation_calls_for_stateless_input rewrites every ImageGenerationCall into a user InputImage without checking status. Failed/in-progress calls can carry empty or invalid result, so this injects bogus data URLs into later prompts and can break multimodal requests or pollute context. Gate rewriting on successful completion and non-empty image data.
Useful? React with 👍 / 👎.
enabling client-side to process with image-generation capabilities (setting app-server)