Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31ad86bcdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Example: Start a turn (invoke a plugin) | ||
|
|
||
| Invoke a plugin by including a UI mention token such as `@sample` in the text input and adding a `mention` input item with the exact `plugin://<plugin-name>@<marketplace-name>` path returned by `plugin/list`. |
There was a problem hiding this comment.
This sentence says the plugin://<plugin>@<marketplace> mention path is “returned by plugin/list”, but that API currently returns plugin name/source/enabled only (no mention path/id). Clients following this doc will look for a non-existent field and fail to build valid plugin mentions unless they guess the key format.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
We will add it soon.it will be called id.
| @@ -178,12 +178,14 @@ impl<'a> ToolMentions<'a> { | |||
| pub(crate) enum ToolMentionKind { | |||
There was a problem hiding this comment.
maybe move this file out of the skills folder as it is used for more than just skills? no preference.
There was a problem hiding this comment.
fair, will split up that file in a follow up so this pr stays small.
2 participants
What
Add structured
@pluginparsing and TUI support for plugin mentions.@display_nameparsing to structuredplugin://...mentions viaUserInput::Mentionand[$...](plugin://...)links in text, same pattern as apps/skills.$. Load plugin capability summaries and feed them into the composer; plugin mentions appear alongside skills and apps.$Builds on #13510. Currently clients have to build their own
idviaplugin@marketplaceand filter plugins to show byenabled, but we will addidandavailableas fields returned fromplugin/listsoon.####Tests
Added tests, verified locally.