Stabilize websocket test server binding#14002
Merged
aibrahim-oai merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
aibrahim-oai
force-pushed
the
codex/flaky-test-stabilization-missing-websocket
branch
from
41aa2ff to
93441b0
Compare
aibrahim-oai
deleted the
codex/flaky-test-stabilization-missing-websocket
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1:0itself and read back the actual bound websocket address from stderrWhy this fixes the flake
The previous harness reserved a port in the test process, dropped it, and then asked the server process to bind that same address. On busy runners there is a race between releasing the reservation and the child process rebinding it, which can produce sporadic startup failures. Binding to port
0inside the server removes that race entirely, and waiting for the server to report the real bound address makes the tests connect only after the listener is actually ready.