Skip to content

Stabilize guardian approval coverage#14103

Merged
aibrahim-oai merged 3 commits intomainfrom
dev/flaky-guardian-approval-coverage
Mar 9, 2026
Merged

Stabilize guardian approval coverage#14103
aibrahim-oai merged 3 commits intomainfrom
dev/flaky-guardian-approval-coverage

Conversation

@aibrahim-oai
Copy link
Collaborator

Summary

  • align the guardian permission test with the actual sandbox policy it widens and use a slightly larger Windows-only timeout budget
  • expose the additional-permissions normalization helper to the guardian test module
  • replace the guardian popup snapshot assertion with targeted string assertions

Why this fixes the flake

This group was carrying two separate sources of drift. The guardian core test widened derived sandbox policies without updating the source sandbox policy, and it used a Windows command/timeout combination that was too tight on slower runners. Separately, the TUI test was snapshotting the full popup even though unrelated feature text changes were the only thing moving. The new assertions keep coverage on the guardian entry itself while removing unrelated snapshot churn.

@aibrahim-oai aibrahim-oai requested review from charley-oai and removed request for jif-oai March 9, 2026 17:57
@aibrahim-oai aibrahim-oai merged commit e03e9b6 into main Mar 9, 2026
30 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/flaky-guardian-approval-coverage branch March 9, 2026 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants