Enforce single tool output type in codex handlers#14157
Merged
pakrym-oai merged 12 commits intomainfrom Mar 10, 2026
Merged
Conversation
…e-single-output-type-for
pakrym-oai
commented
Mar 10, 2026
|
|
||
| pub struct McpHandler; | ||
|
|
||
| pub enum McpHandlerOutput { |
Collaborator
Author
There was a problem hiding this comment.
This can be simplified and I'll do it as a followup.
pakrym-oai
commented
Mar 10, 2026
| } | ||
|
|
||
| #[async_trait] | ||
| trait AnyToolHandler: Send + Sync { |
Collaborator
Author
There was a problem hiding this comment.
This is so registry can store non-generic handlers.
aibrahim-oai
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll need to associate output schema with each tool. Each tool can only have on output type.