Make collab model metadata accurate on completion#14410
Merged
aibrahim-oai merged 4 commits intomainfrom Mar 12, 2026
Merged
Conversation
Add the spawned agent's model and reasoning effort to app-server collab turn items and notifications so turn history matches spawn events. Co-authored-by: Codex <noreply@openai.com>
Ignore newly added spawn metadata fields in the TUI spawn-end destructure so the updated event type keeps compiling. Co-authored-by: Codex <noreply@openai.com>
Remove the unnecessary clone on spawn reasoning effort and add app-server integration coverage for spawn item model metadata. Co-authored-by: Codex <noreply@openai.com>
This was referenced Mar 12, 2026
owenlin0
approved these changes
Mar 12, 2026
Filter the turn completion assertion to the parent thread so the spawn metadata integration test is robust to child-first completion ordering. Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.