feature: reuse skill-scoped managed network proxies for skill scripts by celia-oai · Pull Request #14416 · openai/codex

celia-oai · 2026-03-12T01:52:25Z

Summary

This follows up the managed-network override work for skills by wiring those overrides into shell execution. Before this change, skill scripts still reused the session-level managed network proxy, so per-skill allow/deny domain overrides were not applied through a dedicated proxy.

add NetworkProxySpec helpers to apply managed_network_override settings and derive a normalized cache key so equivalent specs reuse the same proxy
introduce a shared SkillNetworkProxyCache in session services and thread it through session and subagent construction
update unix escalation to resolve the owning skill for a script, start or reuse the matching shared proxy, and fall back to the session proxy when no skill override applies
add unit coverage for partial override replacement and normalized cache-key reuse

Follow-up to feat: support skill-scoped managed network domain overrides in skill config #14522

Testing

tested with a skill that executes fetch_example.sh which fetches from www.example.com.

case 1

with the following skill permission:

permissions:
  network:
    enabled: true

result:

"aggregatedOutput": "\nHTTP_STATUS:000\ncurl: (56) CONNECT tunnel failed, response 403\n",

That's because the program uses the allowed_domain of the default network proxy and www.example.com is not in the allowed_domain.

case 2

with the following permission:

permissions:
  network:
    enabled: true
    allowed_domains:
      - "www.example.com"

result:

<       "aggregatedOutput": "pyenv: cannot rehash: /Users/celia/.pyenv/shims isn't writable\n<!doctype html><html lang=\"en\"><head><title>Example Domain</title><meta name=\"viewport\" content=\"width=device-width, initial-scale=1\"><style>body{background:#eee;width:60vw;margin:15vh auto;font-family:system-ui,sans-serif}h1{font-size:1.5em}div{opacity:0.8}a:link,a:visited{color:#348}</style></head><body><div><h1>Example Domain</h1><p>This domain is for use in documentation examples without needing permission. Avoid use in operations.</p><p><a href=\"https://iana.org/domains/example\">Learn more</a></p></div></body></html>\n\nHTTP_STATUS:200\n",

fetched the website correctly.

bolinfest · 2026-03-18T21:57:58Z

+    ) -> Self {
+        let mut spec = self.clone();
+        if let Some(allowed_domains) = managed_network_override.allowed_domains.as_ref() {
+            spec.config.network.allowed_domains = allowed_domains.clone();


This is why we really need this to be a map rather than a list.

bolinfest · 2026-03-18T22:05:24Z

 use std::sync::Arc;

+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub(crate) struct SkillNetworkProxyKey(String);


Why not just use a regular struct for this and rely on #[derive(Eq, Hash)]? Though you will need a constructor like shared_skill_proxy_key() that ensures the fields are sorted when this is constructed.

Or if you want to distill it down to a single value, why not use sha2::Digest instead of an arbitrarily long String?

bolinfest · 2026-03-18T22:07:09Z

 }

 struct CoreShellCommandExecutor {
+    session: Option<Arc<crate::codex::Session>>,


When is this None?

bolinfest · 2026-03-18T22:12:54Z

 async fn prepare_escalated_exec_turn_default_preserves_macos_seatbelt_extensions() {
    let cwd = AbsolutePathBuf::from_absolute_path(std::env::temp_dir()).unwrap();
    let executor = CoreShellCommandExecutor {
+        session: None,


If it's only None in tests, then ideally we would use a dummy Session or something so the business logic doesn't have to deal with the None case.

bolinfest · 2026-03-18T22:27:07Z

+        let Some(session) = self.session.as_ref() else {
+            return Ok(self.network.clone());
+        };
+        let Some(skill) =
+            find_skill_for_program(session.as_ref(), self.sandbox_policy_cwd.as_path(), program)
+                .await
+        else {
+            return Ok(self.network.clone());
+        };
+        if let Some(network) = session.get_or_start_skill_network_proxy(&skill).await? {


I think you can collapse these ifs such that Ok(self.network.clone()) only appears once?

bolinfest · 2026-03-18T22:34:12Z

+
+#[derive(Default)]
+pub(crate) struct SkillNetworkProxyCache {
+    #[cfg_attr(not(unix), allow(dead_code))]


Why shouldn't this be available on Windows? I thought what we have is cross-platform?

this is not not available on windows, it's not called because only unix_escalation path hits it

bolinfest · 2026-03-18T22:36:05Z

+            return Ok(Arc::clone(proxy));
+        }
+
+        let proxy = Arc::new(start().await?);


Can we find a way to represent this so that we do not have to await while holding the mutex for proxies?

github-actions · 2026-04-02T06:27:19Z

Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR.

celia-oai force-pushed the dev/cc/multi-proxy branch 7 times, most recently from ea68e43 to 9640836 Compare March 12, 2026 23:27

celia-oai changed the base branch from main to dev/cc/skill-override March 12, 2026 23:27

celia-oai force-pushed the dev/cc/multi-proxy branch from 9640836 to 1d511cf Compare March 12, 2026 23:46

celia-oai force-pushed the dev/cc/skill-override branch from 19236d6 to 2da4e05 Compare March 13, 2026 03:32

Base automatically changed from dev/cc/skill-override to main March 13, 2026 04:45

celia-oai force-pushed the dev/cc/multi-proxy branch 7 times, most recently from 4925e68 to d0d7ad8 Compare March 13, 2026 23:23

celia-oai changed the title ~~draft~~ feature: reuse skill-scoped managed network proxies for skill scripts Mar 13, 2026

celia-oai requested review from bolinfest and viyatb-oai March 14, 2026 20:00

celia-oai marked this pull request as ready for review March 14, 2026 20:00

celia-oai force-pushed the dev/cc/multi-proxy branch 4 times, most recently from 345691e to 9d82ebc Compare March 18, 2026 22:10

bolinfest reviewed Mar 18, 2026

View reviewed changes

celia-oai force-pushed the dev/cc/multi-proxy branch 3 times, most recently from 297dea1 to 7b29237 Compare March 19, 2026 01:14

celia-oai force-pushed the dev/cc/multi-proxy branch 2 times, most recently from 339faab to 0eb91ed Compare March 19, 2026 01:27

changes

a39c2d6

celia-oai force-pushed the dev/cc/multi-proxy branch from 0eb91ed to a39c2d6 Compare March 19, 2026 01:40

github-actions Bot mentioned this pull request Mar 19, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-19 compasify/agents-radar#55

Open

celia-oai force-pushed the dev/cc/multi-proxy branch 2 times, most recently from 41655df to ac4c459 Compare March 19, 2026 02:34

changes'

4fbccee

celia-oai force-pushed the dev/cc/multi-proxy branch from ac4c459 to 4fbccee Compare March 19, 2026 02:49

github-actions Bot closed this Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: reuse skill-scoped managed network proxies for skill scripts#14416

feature: reuse skill-scoped managed network proxies for skill scripts#14416
celia-oai wants to merge 2 commits intomainfrom
dev/cc/multi-proxy

celia-oai commented Mar 12, 2026 •

edited by bolinfest

Loading

Uh oh!

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

celia-oai Mar 19, 2026

Uh oh!

bolinfest Mar 18, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

celia-oai commented Mar 12, 2026 • edited by bolinfest Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

case 1

case 2

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

celia-oai commented Mar 12, 2026 •

edited by bolinfest

Loading