Conversation
139eaf7 to
ce9a5a6
Compare
07f8ccc to
5b505bb
Compare
2e751fd to
cfc2e47
Compare
7e41132 to
7308616
Compare
f98685f to
f9a06aa
Compare
joshka-oai
approved these changes
Mar 16, 2026
| apply_patch_tool_type: None, | ||
| web_search_tool_type: Default::default(), | ||
| truncation_policy: TruncationPolicyConfig::bytes(10_000), | ||
| truncation_policy: TruncationPolicyConfig::bytes(/*limit*/ 10_000), |
Collaborator
There was a problem hiding this comment.
This seems like one example of where this is a little overeager - it's the only place I found in reading a majority of the fixes though, so no big deal (and not worth fixing).
3193fbb to
95eb498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Once the repo-local lint exists,
codex-rsneeds to follow the checked-in convention and CI needs to keep it from drifting. This commit applies the fallback/*param*/style consistently across existing positional literal call sites without changing those APIs.The longer-term preference is still to avoid APIs that require comments by choosing clearer parameter types and call shapes. This PR is intentionally the mechanical follow-through for the places where the existing signatures stay in place.
After rebasing onto newer
main, the rollout also had to cover newly introducedtui_app_servercall sites. That made it clear the first cut of the CI job was too expensive for the common path: it was spending almost as much time installingcargo-dylintand re-testing the lint crate as a representative test job spends running product tests. The CI update keeps the full workspace enforcement but trims that extra overhead from ordinarycodex-rsPRs.What changed
argument_comment_lintjob inrust-cicodex-rswith exact/*param*/comments, including the rebasedtui_app_servercall sites that now fall under the lint/*param*/and leaving string and char literals uncommentedcargo-dylint,dylint-link, and the relevant Cargo registry/git metadata in the lint jobcargo teststep runs only whentools/argument-comment-lint/*orrust-ci.ymlchangescodex-rsworkspace, so product-code enforcement is unchangedMost of the code changes in this commit are intentionally mechanical comment rewrites or insertions driven by the lint itself.
Verification
./tools/argument-comment-lint/run.sh --workspacecargo test -p codex-tui-app-server -p codex-tui.github/workflows/rust-ci.ymllocally with PyYAML