Skip to content

core: introduce reference turn context state#14822

Open
charley-oai wants to merge 7 commits intomainfrom
cc/reference-turn-context-state
Open

core: introduce reference turn context state#14822
charley-oai wants to merge 7 commits intomainfrom
cc/reference-turn-context-state

Conversation

@charley-oai
Copy link
Contributor

@charley-oai charley-oai commented Mar 16, 2026

Summary

  • move reference-turn bookkeeping into a dedicated ReferenceTurnContextState owned by the context manager
  • store one TurnContextItem plus a compaction-shadow bit so previous_turn_settings() and the model-visible reference baseline stay in lockstep
  • route normal execution and reverse rollout reconstruction through the same model-visible turn-context bookkeeping, with regression coverage for rollback, compaction, and fork/replay hydration cases

Testing

  • cargo test -p codex-core
  • just fix -p codex-core
  • just fmt

cargo test -p codex-core still hits the pre-existing tools::js_repl::tests::js_repl_imported_local_files_can_access_repl_globals tempdir permission failure while downloading dotslash.

charley-oai added a commit that referenced this pull request Mar 16, 2026
Handle the Interrupted agent status in the TUI app-server multi-agent status summary and cover it with a snapshot.

Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the cc/reference-turn-context-state branch from de27d6f to 6e2e15a Compare March 16, 2026 19:03
@charley-oai
Copy link
Contributor Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e2e15a38d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai force-pushed the cc/reference-turn-context-state branch 2 times, most recently from 5fb58a9 to 6f02ad5 Compare March 24, 2026 17:19
@charley-oai
Copy link
Contributor Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f25d301cff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai and others added 6 commits March 24, 2026 13:54
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the cc/reference-turn-context-state branch from f25d301 to 023ccef Compare March 24, 2026 21:06
Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Contributor Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39d71da00b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant