Skip to content

Extract codex-auth from codex-core#15029

Closed
aibrahim-oai wants to merge 5 commits intocodex/split-core-config-loaderfrom
codex/split-core-auth
Closed

Extract codex-auth from codex-core#15029
aibrahim-oai wants to merge 5 commits intocodex/split-core-config-loaderfrom
codex/split-core-auth

Conversation

@aibrahim-oai
Copy link
Collaborator

Summary

  • extract auth storage, token data, and auth environment telemetry into codex-auth
  • slim codex-core auth modules down to wrappers over the new crate
  • update login to consume the extracted auth crate

Testing

  • cargo test -p codex-auth
  • cargo test -p codex-login --no-run
  • cargo test -p codex-core --lib --no-run

Co-authored-by: Codex <noreply@openai.com>
@aibrahim-oai
Copy link
Collaborator Author

@codex review this

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

AuthDotJson::from_external_tokens(&refreshed).map_err(RefreshTokenError::Transient)?;

P0 Badge Restore external-token constructor call

AuthDotJson::from_external_tokens is still called here after extraction, but codex-auth's AuthDotJson no longer defines that associated function (it only has from_external_access_token). This introduces a compile-time failure (E0599) in codex-core, blocking builds and the external-auth refresh path.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aibrahim-oai and others added 4 commits March 18, 2026 05:25
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant