Add sandboxed upload_file and download_file tools#15131
Closed
caseychow-oai wants to merge 7 commits intomainfrom
Closed
Add sandboxed upload_file and download_file tools#15131caseychow-oai wants to merge 7 commits intomainfrom
caseychow-oai wants to merge 7 commits intomainfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Contributor
Author
|
Additional smoke results after the initial draft:
Added automated helper coverage in |
Keep auth headers on the backend link request, but do not forward them to the backend-provided blob download URL. Add regression coverage for the blob fetch header set. Co-authored-by: Codex <noreply@openai.com>
Add the new file-transfer tools to the core tool expectation suites and satisfy the argument-comment lint in the file transfer handler. Co-authored-by: Codex <noreply@openai.com>
Register upload_file and download_file as built-in tools instead of gating them on experimental_supported_tools, and add regression coverage for the ungated behavior. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upload_fileanddownload_filetools backed by a newcodex-file-transferhelper crateKey Decisions
upload_fileanddownload_fileare built-in tools, not experimental tools; they are registered unconditionally rather than being gated onexperimental_supported_toolsdownload_urldoes not forward ChatGPT auth headers; only the initial authenticated metadata request doescp-style semantics, including basename sanitization when writing into an existing directoryValidation
just exec --json --sandbox danger-full-access --skip-git-repo-check ...for upload and download round-tripSmoke notes
just execruns with cwd atcodex-rs, so relative file paths resolve there during smoke testsopenai-file://v1/...URI and an immediate download wrote matching bytes (some data) to/tmp/codex-download-smoke.txt