Skip to content

Log automated reviewer approval sources distinctly#15201

Merged
gabec-openai merged 1 commit intomainfrom
codex/automated-reviewer-approval-source
Mar 19, 2026
Merged

Log automated reviewer approval sources distinctly#15201
gabec-openai merged 1 commit intomainfrom
codex/automated-reviewer-approval-source

Conversation

@gabec-openai
Copy link
Contributor

Summary

  • log guardian-reviewed tool approvals as source=automated_reviewer in codex.tool_decision
  • keep direct user approvals as source=user and config-driven approvals as source=config

Testing

  • /Users/gabec/.codex/skills/codex-oss-fastdev/scripts/codex-rs-fmt-quiet.sh
  • /Users/gabec/.codex/skills/codex-oss-fastdev/scripts/codex-rs-test-quiet.sh -p codex-otel (fails in sandboxed loopback bind tests under otel/tests/suite/otlp_http_loopback.rs)
  • cargo test -p codex-core guardian -- --nocapture (original-tree run reached Guardian tests and only hit sandbox-related listener/proxy failures)

Route guardian-reviewed tool decisions through the automated_reviewer telemetry source so exported codex.tool_decision logs are distinguishable from direct user approvals.

Co-authored-by: Codex <noreply@openai.com>
@gabec-openai gabec-openai merged commit fe287ac into main Mar 19, 2026
33 checks passed
@gabec-openai gabec-openai deleted the codex/automated-reviewer-approval-source branch March 19, 2026 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants