Pin Python SDK app-server stdio to UTF-8 on Windows#15244
Merged
shaqayeq-oai merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
owenlin0
approved these changes
Mar 20, 2026
owenlin0
reviewed
Mar 20, 2026
| from codex_app_server.client import AppServerClient, AppServerConfig | ||
|
|
||
|
|
||
| def test_start_launches_subprocess_with_utf8_text_io( |
Collaborator
There was a problem hiding this comment.
i find that codex can add tests that are not super high signal. imo this is one of them (just asserting that we pass encoding = "utf-8" to Popen)
Collaborator
Author
There was a problem hiding this comment.
yea i agree. will remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Pin the Python app-server SDK subprocess pipes to UTF-8 so Windows users on non-UTF-8 locales do not hit
UnicodeDecodeErrorwhen thecodexchild emits UTF-8 text.encoding="utf-8"to thesubprocess.Popen(...)call inAppServerClient.start()python -m pytest sdk/python/tests/test_client_rpc_methods.py sdk/python/tests/test_client_process_launch.py sdk/python/tests/test_public_api_runtime_behavior.pyFixes #14311.