Skip to content

feat: change multi-agent to use path-like system instead of uuids#15313

Merged
jif-oai merged 8 commits intomainfrom
jif/task-path
Mar 20, 2026
Merged

feat: change multi-agent to use path-like system instead of uuids#15313
jif-oai merged 8 commits intomainfrom
jif/task-path

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Mar 20, 2026

This PR add an URI-based system to reference agents within a tree. This comes from a sync between research and engineering.

The main agent (the one manually spawned by a user) is always called /root. Any sub-agent spawned by it will be /root/agent_1 for example where agent_1 is chosen by the model.

Any agent can contact any agents using the path.

Paths can be used either in absolute or relative to the calling agents

Resume is not supported for now on this new path

@jif-oai
Copy link
Collaborator Author

jif-oai commented Mar 20, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85edb9527f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
Copy link
Collaborator Author

jif-oai commented Mar 20, 2026

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa2b1d17db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +185 to +186
.get_agent_path()
.unwrap_or_else(AgentPath::root)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Derive child task paths from the true parent path

thread_spawn_source falls back to AgentPath::root() when parent_session_source.get_agent_path() is missing. Since spawn_agent.task_name is optional, non-root agents can be pathless; when they spawn a named child, that child is incorrectly created under /root/... instead of under the caller. This breaks relative tree semantics and can cause cross-branch path collisions.

Useful? React with 👍 / 👎.

@jif-oai jif-oai merged commit 79ad7b2 into main Mar 20, 2026
35 checks passed
@jif-oai jif-oai deleted the jif/task-path branch March 20, 2026 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants