Skip to content

Remove legacy app-server notification handling from tui_app_server#15390

Merged
etraut-openai merged 2 commits intomainfrom
codex/pr-15106-tui-legacy-notifications
Mar 21, 2026
Merged

Remove legacy app-server notification handling from tui_app_server#15390
etraut-openai merged 2 commits intomainfrom
codex/pr-15106-tui-legacy-notifications

Conversation

@etraut-openai
Copy link
Collaborator

@etraut-openai etraut-openai commented Mar 21, 2026

As part of moving the TUI onto the app server, we added some temporary handling of some legacy events. We've confirmed that these do not need to be supported, so this PR removes this support from the tui_app_server, allowing for additional simplifications in follow-on PRs. These events are needed only for very old rollouts. None of the other app server clients (IDE extension or app) support these either.

Summary

  • stop translating legacy codex/event/* notifications inside tui_app_server
  • remove the TUI-side legacy warning and rollback buffering/replay paths that were only fed by those notifications
  • keep the lower-level app-server and app-server-client legacy event plumbing intact so PR Refactor codex exec to use typed app-server APIs #15106 can rebase on top and handle the remaining exec/lower-layer migration separately

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcb4222152

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05b63be19f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai merged commit b023650 into main Mar 21, 2026
36 checks passed
@etraut-openai etraut-openai deleted the codex/pr-15106-tui-legacy-notifications branch March 21, 2026 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant