Update config handling to rely on async ExecutorFileSystem#15408
Closed
pakrym-oai wants to merge 1 commit intomainfrom
Closed
Update config handling to rely on async ExecutorFileSystem#15408pakrym-oai wants to merge 1 commit intomainfrom
pakrym-oai wants to merge 1 commit intomainfrom
Conversation
pakrym-oai
force-pushed
the
pakry/config-test
branch
from
3cc1594 to
45aac23
Compare
This was referenced Mar 22, 2026
bolinfest
reviewed
Mar 23, 2026
| fn load_catalog_json(path: &AbsolutePathBuf) -> std::io::Result<ModelsResponse> { | ||
| let file_contents = std::fs::read_to_string(path)?; | ||
| fn absolute_path_for_filesystem_read(path: &Path) -> std::io::Result<AbsolutePathBuf> { | ||
| let absolute_path = if path.is_absolute() { |
Collaborator
There was a problem hiding this comment.
I believe is_absolute() is platform-dependent.
bolinfest
reviewed
Mar 23, 2026
| }) | ||
| } | ||
|
|
||
| async fn read_text_file( |
Collaborator
There was a problem hiding this comment.
Why is there a helper for this? Shouldn't ExecutorFileSystem provide this directly?
bolinfest
reviewed
Mar 23, 2026
| return Ok(()); | ||
| } | ||
|
|
||
| write_atomically(&write_paths.write_path, &document.doc.to_string()).with_context(|| { |
Collaborator
There was a problem hiding this comment.
So we lose atomic updates here, correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing