Add CLI streaming integration tests#1542
Merged
aibrahim-oai merged 6 commits intomainfrom Jul 13, 2025
Merged
Conversation
aibrahim-oai
added
the
codex
ChatGPT Codex Connector
bolinfest
added
the
code-review
github-actions
Bot
added
codex-review-in-progress
and removed
code-review
Contributor
SummaryAdds two Tokio integration tests ( Notes
ReviewLooks great—nice to see end-to-end coverage for both streaming paths. Suggestions
|
github-actions
Bot
added
codex-review-completed
and removed
codex-review-in-progress
labels
bolinfest
approved these changes
Jul 12, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Just some small suggestions!
| } | ||
|
|
||
| let server = MockServer::start().await; | ||
| let sse = concat!( |
Collaborator
There was a problem hiding this comment.
I would use r# here. Since it isn't a format string, you won't have to escape {.
| "model_providers.mock={{ name = \"mock\", base_url = \"{}/v1\", env_key = \"PATH\", wire_api = \"chat\" }}", | ||
| server.uri() | ||
| ); | ||
| let mut cmd = Command::new("cargo"); |
Collaborator
There was a problem hiding this comment.
Command::cargo_bin("codex-rs") instead?
| let server = MockServer::start().await; | ||
| let sse = concat!( | ||
| "data: {\"choices\":[{\"delta\":{\"content\":\"hi\"}}]}\n\n", | ||
| "data: {\"choices\":[{\"delta\":{}}]}\n\n", |
Collaborator
There was a problem hiding this comment.
Is this empty {} the way it signals the end of the stream?
| std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("tests/cli_responses_fixture.sse"); | ||
|
|
||
| let home = TempDir::new().unwrap(); | ||
| let mut cmd = Command::new("cargo"); |
Collaborator
There was a problem hiding this comment.
Command::cargo_bin here, as well?
| .arg("exec") | ||
| .arg("--skip-git-repo-check") | ||
| .arg("hello?"); | ||
| cmd.current_dir(env!("CARGO_MANIFEST_DIR")) |
Collaborator
There was a problem hiding this comment.
note that if you need codex to use a specific cwd, it has a --cd/-C option.
aibrahim-oai
deleted the
codex/implement-end-to-end-cli-integration-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo runto invoke the CLI during testsTesting
cargo test -p codex-core --test cli_stream -- --nocapturecargo clippy --all-targets --all-features -- -D warningshttps://chatgpt.com/codex/tasks/task_i_68715980bbec8321999534fdd6a013c1