Skip to content

fix(core): default approval behavior for mcp missing annotations#15519

Merged
fouad-openai merged 4 commits intomainfrom
update-mcp-default-approval-behavior
Mar 25, 2026
Merged

fix(core): default approval behavior for mcp missing annotations#15519
fouad-openai merged 4 commits intomainfrom
update-mcp-default-approval-behavior

Conversation

@fouad-openai
Copy link
Collaborator

  • Changed requires_mcp_tool_approval to apply MCP spec defaults when annotations are missing.
  • Unannotated tools now default to:
    • readOnlyHint = false
    • destructiveHint = true
    • openWorldHint = true
  • This means unannotated MCP tools now go through approval/ARC monitoring instead of silently bypassing it.
  • Explicitly read-only tools still skip approval unless they are also explicitly marked destructive.

Previous behavior
Failed open for missing annotations, which was unsafe for custom MCP tools that omitted or forgot annotations.

@fouad-openai fouad-openai merged commit 32c4993 into main Mar 25, 2026
62 of 66 checks passed
@fouad-openai fouad-openai deleted the update-mcp-default-approval-behavior branch March 25, 2026 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants