Unify realtime stop handling in TUI#15529
Merged
aibrahim-oai merged 4 commits intomainfrom Mar 23, 2026
Merged
Conversation
Route /realtime, Ctrl+C, and deleted realtime meters through the same stop path while keeping generic transcription cleanup side-effect free. Co-authored-by: Codex <noreply@openai.com>
Relax the shared realtime stop helper visibility so the chat widget call sites can reuse it across modules. Co-authored-by: Codex <noreply@openai.com>
Update the mirrored realtime tests to assert the new explicit deleted-meter stop path instead of the removed placeholder side effect. Co-authored-by: Codex <noreply@openai.com>
Collapse the mirrored recording meter frame scheduling branches to satisfy clippy after the realtime stop-path change. Co-authored-by: Codex <noreply@openai.com>
charley-oai
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing