Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32c2995cf4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(child_agent_path) = child_agent_path | ||
| && child_thread | ||
| .as_ref() | ||
| .map(|thread| thread.enabled(Feature::MultiAgentV2)) | ||
| .unwrap_or(true) | ||
| { | ||
| let AgentStatus::Completed(Some(content)) = &status else { | ||
| return; |
There was a problem hiding this comment.
In maybe_start_completion_watcher, a missing child thread is treated as MultiAgentV2 by default (unwrap_or(true)). If a legacy child with an agent_path is removed before this check, execution enters the v2 branch and then returns for non-Completed(Some(_)) states, so the parent never gets the old completion notification. This regresses legacy task_name/path-based spawn flows.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
V1 can't have agent_path
|
@codex review |
1 participant
Custom watcher that sends an InterAgentCommunication on end of turn