[codex] Stabilize compact resume and fork snapshot flaky tests#15605
Merged
charley-oai merged 3 commits intomainfrom Mar 24, 2026
Merged
[codex] Stabilize compact resume and fork snapshot flaky tests#15605charley-oai merged 3 commits intomainfrom
charley-oai merged 3 commits intomainfrom
Conversation
Contributor
Author
|
@codex review |
Co-authored-by: Codex <noreply@openai.com>
Contributor
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
34fd7c5 to
1fb0e60
Compare
Co-authored-by: Codex <noreply@openai.com>
rhan-oai
approved these changes
Mar 24, 2026
jif-oai
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compact_resume_after_second_compaction_preserves_historyby asserting against the real/responsesrequest order and accepting the preserved post-compaction block even when earlier history precedes itfork_startup_context_then_first_turn_diff_snapshotby waiting for the parent rollout to persist the pre-fork user turn before forking from the JSONL pathRoot cause
compact_resume_after_second_compaction_preserves_historycombined overlappingmount_sse_once_matchrecorders and indexed into a synthetic request list, so matcher evaluation order could duplicate requests and skew the expected history slicefork_startup_context_then_first_turn_diff_snapshotread the fork source rollout immediately afterTurnComplete, but the rollout writer persists asynchronously, so the fork sometimes missed the sourcefork seedturn on diskImpact
Validation
just fmtjust argument-comment-lintcargo test -p codex-core compact_resume_after_second_compaction_preserves_history -- --nocapturecargo test -p codex-core compact_resume_after_second_compaction_preserves_history -- --nocapture10xcargo test -p codex-core fork_startup_context_then_first_turn_diff_snapshot -- --nocapturecargo test -p codex-core(the snapshot fix passed; one unrelated failure remained intools::js_repl::tests::js_repl_imported_local_files_can_access_repl_globalsbecausemktempwas denied during dotslash setup)