Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Propagate connector id and connector name into the mcp.tools.call span and add tracing coverage for Codex Apps and stdio MCP paths. Co-authored-by: Codex <noreply@openai.com>
Drop the Responses-specific tracing changes from this branch so the draft PR focuses on MCP spans and MCP transport timing. Co-authored-by: Codex <noreply@openai.com>
nicholasclark-openai
changed the title
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Keep the narrow MCP span PR out of the integration test suite by asserting the span fields in mcp_tool_call_tests instead. Co-authored-by: Codex <noreply@openai.com>
owenlin0
approved these changes
Mar 25, 2026
codex-rs/core/src/mcp_tool_call.rs
Outdated
| let conversation_id = session.conversation_id.to_string(); | ||
| span.record("conversation.id", conversation_id.as_str()); | ||
| span.record("session.id", conversation_id.as_str()); | ||
| span.record("turn.id", turn_context.sub_id.as_str()); |
Collaborator
There was a problem hiding this comment.
nit: interesting, why do it like this instead of defining inline above?
Contributor
Author
There was a problem hiding this comment.
Codex decision that I missed. It was just a compile-time/runtime split
nicholasclark-openai
changed the title
nicholasclark-openai
force-pushed
the
nicholasclark/2026-03-23-server-spans
branch
2 times, most recently
from
6f5cefc to
16d57b4
Compare
Co-authored-by: Codex <noreply@openai.com>
nicholasclark-openai
force-pushed
the
nicholasclark/2026-03-23-server-spans
branch
from
16d57b4 to
89161d4
Compare
nicholasclark-openai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp.tools.callspan around MCP tool execution in coremcp_tool_call_testsinstead of broadening the integration test suiteIncluded Changes
codex-rs/core/src/mcp_tool_call.rs: wrap the existing MCP tool call inmcp.tools.calland inlineconversation.id,session.id, andturn.idin the span initializercodex-rs/core/src/mcp_tool_call_tests.rs: assert the MCP span records the expected correlation and server fieldsTesting
cargo test -p codex-corejust fmtNotes
cargo test -p codex-corestill hits existing unrelated failures in guardian-config tests and the sandboxed JS REPLmktemptestcargo testwas not run