Skip to content

Drop sandbox_permissions from sandbox exec requests#15665

Merged
pakrym-oai merged 2 commits intomainfrom
pakrym/drop-sandbox-permissions
Mar 24, 2026
Merged

Drop sandbox_permissions from sandbox exec requests#15665
pakrym-oai merged 2 commits intomainfrom
pakrym/drop-sandbox-permissions

Conversation

@pakrym-oai
Copy link
Collaborator

@pakrym-oai pakrym-oai commented Mar 24, 2026

Summary

  • drop sandbox_permissions from the sandboxing ExecOptions and ExecRequest adapter types
  • remove the now-unused plumbing from shell, unified exec, JS REPL, and apply-patch runtime call sites
  • default reconstructed ExecParams to SandboxPermissions::UseDefault where the lower-level API still requires the field

Testing

  • just fmt
  • just argument-comment-lint
  • cargo test -p codex-core (still running locally; first failures observed in suite::cli_stream::responses_mode_stream_cli, suite::cli_stream::responses_mode_stream_cli_supports_openai_base_url_config_override, and suite::cli_stream::responses_mode_stream_cli_supports_openai_base_url_env_fallback)

@pakrym-oai pakrym-oai enabled auto-merge (squash) March 24, 2026 19:43
@pakrym-oai pakrym-oai merged commit 0b619af into main Mar 24, 2026
38 of 40 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/drop-sandbox-permissions branch March 24, 2026 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants