Skip to content

tui_app_server: tolerate missing rate limits while logged out#15670

Merged
etraut-openai merged 1 commit intomainfrom
etraut/tui-app-server-bootstrap-rate-limits
Mar 24, 2026
Merged

tui_app_server: tolerate missing rate limits while logged out#15670
etraut-openai merged 1 commit intomainfrom
etraut/tui-app-server-bootstrap-rate-limits

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Mar 24, 2026

Summary

Fixes a tui_app_server bootstrap failure when launching the CLI while logged out.

Root cause

During TUI bootstrap, tui_app_server fetched account/rateLimits/read unconditionally and treated failures as fatal. When the user was logged out, there was no ChatGPT account available, so that RPC failed and aborted startup with:

Error: account/rateLimits/read failed during TUI bootstrap

Changes

  • Only fetch bootstrap rate limits when OpenAI auth is required and a ChatGPT account is present
  • Treat bootstrap rate-limit fetch failures as non-fatal and fall back to empty snapshots
  • Log the fetch failure at debug level instead of aborting startup

@fcoury
Copy link
Copy Markdown
Contributor

fcoury commented Mar 24, 2026

@etraut-openai code looks good, I have tested before/after the fix. Before I got the error message and after I got the login flow. LGTM!

@etraut-openai etraut-openai merged commit fc97092 into main Mar 24, 2026
36 checks passed
@etraut-openai etraut-openai deleted the etraut/tui-app-server-bootstrap-rate-limits branch March 24, 2026 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants