[plugins] Add a flag for tool search.#15722
Merged
mzeng-openai merged 3 commits intomainfrom Mar 25, 2026
Merged
Conversation
Collaborator
mzeng-openai
commented
Mar 25, 2026
mzeng-openai
commented
- Add a flag for tool search.
canvrno-oai
approved these changes
Mar 25, 2026
morozow
reviewed
Mar 25, 2026
| config.model_catalog = Some(model_catalog); | ||
| } | ||
|
|
||
| fn configure_apps(config: &mut Config, apps_base_url: &str) { |
There was a problem hiding this comment.
A mutable 'config' argument breaks platform consistency. It is better to keep data changes at a single, direct entry point. At the same time, binding this function directly to 'Config' type limits future extensibility. A trait-based generic would preserve the same flow while allowing extended mutable config types later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.