fix: resolve bwrap from trusted PATH entry#15791
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e0832580e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
viyatb-oai
force-pushed
the
codex/viyatb/fix-bwrap-system-path
branch
from
8f9bf03 to
59aa4bf
Compare
viyatb-oai
changed the title
| const OPENAI_BASE_URL_ENV_VAR: &str = "OPENAI_BASE_URL"; | ||
| #[cfg(target_os = "linux")] | ||
| const SYSTEM_BWRAP_PATH: &str = "/usr/bin/bwrap"; | ||
| const SYSTEM_BWRAP_PROGRAM: &str = "bwrap"; |
There was a problem hiding this comment.
As a follow-up, we should move all the bwrap stuff out of this file (which is already quite large) so we end up with less #[cfg(target_os = "linux")] in here.
There was a problem hiding this comment.
Moved this cleanup to follow-up PR #15898 to keep this PR focused on the behavior change.
|
|
||
| #[cfg(target_os = "linux")] | ||
| #[test] | ||
| fn skips_workspace_local_bwrap_in_search_paths() { |
There was a problem hiding this comment.
All these tests should go in their own file, as well.
There was a problem hiding this comment.
Moved this cleanup to follow-up PR #15898 to keep this PR focused on the behavior change.
viyatb-oai
changed the title
2 participants
Summary
Validation