Auto format code on save and add more details to AGENTS.md#1582
Merged
pakrym-oai merged 7 commits intomainfrom Jul 17, 2025
Merged
Conversation
…ex-runs-more-reliable
…olchain.toml - Pass --all-features to cargo clippy in fix target for broader lint coverage - Remove explicit rustup component add from install target - Add codex-rs/toolchain.toml to manage Rust toolchain and components declaratively
pakrym-oai
commented
Jul 17, 2025
| @@ -0,0 +1,3 @@ | |||
| [toolchain] | |||
| channel = "1.88.0" | |||
Collaborator
Author
There was a problem hiding this comment.
aligns local rust version with ci
pakrym-oai
commented
Jul 17, 2025
| } | ||
|
|
||
| impl<'a> BottomPaneView<'a> for StatusIndicatorView { | ||
| impl BottomPaneView<'_> for StatusIndicatorView { |
Collaborator
Author
There was a problem hiding this comment.
result of running cargo clippy --fix --all-features --tests locally with 1.88
pakrym-oai
commented
Jul 17, 2025
| test: | ||
| cd codex-rs && cargo test --all-features | ||
|
|
||
| install: |
Collaborator
Author
There was a problem hiding this comment.
to be called by codex environment setup
bolinfest
requested changes
Jul 17, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Main question is around the Makefile.
|
|
||
| - Never add or modify any code related to `CODEX_SANDBOX_NETWORK_DISABLED_ENV_VAR`. You operate in a sandbox where `CODEX_SANDBOX_NETWORK_DISABLED=1` will be set whenever you use the `shell` tool. Any existing code that uses `CODEX_SANDBOX_NETWORK_DISABLED_ENV_VAR` was authored with this fact in mind. It is often used to early exit out of tests that the author knew you would not be able to run given your sandbox limitations. | ||
|
|
||
| After making changes to the rust code run `make format` to format the code and `make fix` to fix the code. |
Collaborator
There was a problem hiding this comment.
I know everyone has their favorite tool, but can we stick with the codex-rs/justfile?
I admit that make is more commonly available than just, but it feels a bit weird to have both?
Collaborator
Author
There was a problem hiding this comment.
Completely missed there was a just file
… and rustfmt settings
pakrym-oai
deleted the
pakrym/auto-format-code-on-save-and-make-codex-runs-more-reliable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default vscode config with generally applicable settings.
Adds makefile with some entrypoints for environment setup and to help agents better verify changes.