Fix duplicate /review messages in app-server TUI#15839
Merged
etraut-openai merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cf65fbfe0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptoms
When
/reviewran throughtui_app_server, the TUI could show duplicate review content:>> Code review started: ... <<banner appeared twiceProblem
tui_app_serverwas treating review lifecycle items as renderable content on more than one delivery path.Specifically:
EnteredReviewModewas rendered both when the item started and again when it completedExitedReviewModerendered the review text itself, even though the same review text was also delivered later as the assistant message itemThat meant the same logical review event was committed into history multiple times.
Solution
Make review lifecycle items control state transitions only once, and keep the final review body sourced from the assistant message item:
ItemStartedpath, while still allowing replay to restore it onceExitedReviewModeas a mode-exit/finish-banner event instead of rendering the review body from it