fix(network-proxy): fail closed on network-proxy DNS lookup errors#15909
Merged
viyatb-oai merged 3 commits intomainfrom Mar 26, 2026
Merged
fix(network-proxy): fail closed on network-proxy DNS lookup errors#15909viyatb-oai merged 3 commits intomainfrom
viyatb-oai merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fail closed when the network proxy's local/private IP pre-check hits a DNS lookup error or timeout, instead of treating the hostname as public and allowing the request.
Root cause
host_resolves_to_non_public_ip()returnedfalseon resolver failure, which created a fail-open path in theallow_local_binding = falseboundary. The eventual connect path performs its own DNS resolution later, so a transient pre-check failure is not evidence that the destination is public.Changes
Validation
cargo test -p codex-network-proxycargo clippy -p codex-network-proxy --all-targets -- -D warningsjust fmtjust argument-comment-lint