Conversation
aibrahim-oai
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-coreis already the largest crate incodex-rs, so defaulting to it for new functionality makes it harder to keep the workspace modular. The repo guidance should make it explicit that contributors are expected to look for an existing non-codex-corecrate, or introduce a new crate, before growingcodex-corefurther.What Changed
The \codex-core` cratesection toAGENTS.md`.codex-coreshould be treated as a last resort for new functionality.codex-corecrate when possible, introduce a new workspace crate when that is the cleaner boundary, and push back on PRs that growcodex-coreunnecessarily.