In code mode, rename tools global to functions#16122
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8df0e45f9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set_global(scope, global, "functions", tools.into())?; | ||
| set_global(scope, global, "ALL_FUNCTIONS", all_tools)?; |
There was a problem hiding this comment.
Expose tools/ALL_TOOLS (or update all producers/consumers atomically) before renaming these globals. install_globals now only sets functions and ALL_FUNCTIONS, but code-mode descriptions and callsites still reference tools and ALL_TOOLS (e.g. code-mode/src/description.rs and core code-mode tests). This will cause ReferenceError in existing scripts generated from the current description.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| fn tool_names(body: &Value) -> Vec<String> { | ||
| body.get("tools") |
There was a problem hiding this comment.
this refers to response api field and should stay tools
2 participants
No description provided.