Conversation
xl-openai
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
plugin/listforce-sync path can race app-server startup's curated plugin cache refresh.Startup was capturing the configured curated plugin IDs from the initial config snapshot. If
plugin/listwithforceRemoteSyncremoved curated plugin entries fromconfig.tomlwhile that background refresh was still in flight, the startup task could recreate cache directories for plugins that had just been uninstalled.That leaves the
plugin/listresponse logically correct but the on-disk cache stale, which matches the flaky Ubuntu arm failure seen incodex-app-server::all suite::v2::plugin_list::plugin_list_force_remote_sync_reconciles_curated_plugin_statewhile validating #16047.What
codex-rs/core/src/plugins/manager.rsso startup curated-repo refresh rereads the current userconfig.tomlbefore deciding which curated plugin cache entries to refreshTesting
cargo test -p codex-core configured_curated_plugin_ids_from_codex_home_reads_latest_user_config -- --nocapturecargo test -p codex-app-server suite::v2::plugin_list::plugin_list_force_remote_sync_reconciles_curated_plugin_state -- --nocapturejust argument-comment-lint