Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
core/src/tools/spec.rsstill owned the puretool_searchandtool_suggestspec builders even though that logic no longer neededcodex-coreruntime state. This change continues thecodex-toolsmigration by moving the reusable discovery and suggestion spec construction out ofcodex-coresospec.rsis left with the core-owned policy decisions about when these tools are exposed and what metadata is available.What changed
codex-rs/tools/src/tool_discovery.rswith the sharedtool_searchandtool_suggestspec builders, plus focused unit tests intool_discovery_tests.rs.DiscoverableToolActionandDiscoverableToolTypedeclarations intocodex-toolsso thetool_suggesthandler and the extracted spec builders use the same wire-model enums.core/src/tools/spec.rsto translateToolInfoandDiscoverableToolvalues into neutralcodex-toolsinputs and delegate the actual spec building there.core/src/tools/spec.rsand deleted the now-dead helper methods incore/src/tools/discoverable.rs.codex-rs/tools/README.mdto document that discovery and suggestion models/spec builders now live incodex-tools.Test plan
cargo test -p codex-toolsCARGO_TARGET_DIR=/tmp/codex-core-discovery-specs cargo test -p codex-core --lib tools::spec::CARGO_TARGET_DIR=/tmp/codex-core-discovery-specs cargo test -p codex-core --lib tools::handlers::tool_suggest::just argument-comment-lintReferences