Fix stale /status rate limits in active TUI sessions#16201
Fix stale /status rate limits in active TUI sessions#16201etraut-openai merged 10 commits intomainfrom
Conversation
|
@etraut-openai the code looks good, but since I am physically far away from the server this is running on, there is a very noticeable lag between when I type I know we want to make things as simple as possible but I wonder if we should have a message displayed instantly that indicates we are loading the status and then maybe delete it before showing the actual status? |
etraut-openai
force-pushed
the
etraut/status-rate-limit-update
branch
from
36aea03 to
7d59d6f
Compare
etraut-openai
force-pushed
the
etraut/status-rate-limit-update
branch
from
7d59d6f to
0d00050
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d00050fae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8330ac889
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@fcoury, thanks for the review. That's a good point. I've asked codex to update the implementation as you suggested. I'd appreciate it if you could retry the new version and let me know if it feels better for you. |
|
@etraut-openai it is instant now! |
2 participants
Fix stale weekly limit in
/status(#16194): /status reused the session’s cached rate-limit snapshot, so the weekly remaining limit could stay frozen within an active session.With this change, we now dynamically update the rate limits after status is displayed.
I needed to delete a few low-value test cases from the chatWidget tests because the test.rs file is really large, and the new tests in this PR pushed us over the 512K mandated limit. I'm working on a separate PR to refactor that test file.