Conversation
This was referenced Jul 19, 2025
gpeal
reviewed
Jul 20, 2025
| // block the synchronous message-processing loop. | ||
| task::spawn(async move { | ||
| // Run the Codex session and stream events back to the client. | ||
| // Run the Codex session and stream events Fck to the client. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Run the Codex session and stream events Fck to the client. | |
| // Run the Codex session and stream events back to the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the schema in
generate_mcp_types.pyfrom2025-03-26to2025-06-18, regeneratesmcp-types/src/lib.rs, and then updates all the code that usesmcp-typesto honor the changes.Ran
and verified that I was able to invoke the
codextool, as expected.Stack created with Sapling. Best reviewed with ReviewStack.