Conversation
This was referenced Mar 31, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExternalAuthRefresherwas still shaped around external ChatGPT auth:ExternalAuthTokensalways implied ChatGPT account metadata even when a caller only needed a bearer token.This PR generalizes that contract so bearer-only sources are first-class, while keeping the existing ChatGPT paths strict anywhere we persist or rebuild ChatGPT auth state.
Motivation
This is the first step toward #15189.
The follow-on provider-auth work needs one shared external-auth contract that can do both of these things:
401That should not require a second token result type just because there is no ChatGPT account metadata attached.
What Changed
ExternalAuthTokensto carryaccess_tokenplus optionalExternalAuthChatgptMetadataExternalAuthRefresher::resolve()with a default no-op implementation so refreshers can optionally provide the current token before a request is sentTesting
cargo test -p codex-loginStack created with Sapling. Best reviewed with ReviewStack.