fix: create separate test_support crates to eliminate #[allow(dead_code)] #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
force-pushed
the
pr1667
branch
7 times, most recently
from
b70c5e7 to
ca2e442
Compare
aibrahim-oai
approved these changes
Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a quirk of how implementation tests work in Rust, we had a number of
#[allow(dead_code)]annotations that were misleading because the functions were being used, just not by all integration tests in atests/folder, so when compiling the test that did not use the function, clippy would complain that it was unused.This fixes things by create a "test_support" crate under the
tests/folder that is imported as a dev dependency for the respective crate.