[codex] Add Warp OSC 9 notification support#16878
Draft
jgershen-oai wants to merge 2 commits intomainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Warp terminal support to Codex TUI desktop notifications by detecting Warp sessions via an environment variable and adjusting both backend selection and focus-suppression behavior to match Warp’s focus/visibility model.
Changes:
- Detect Warp sessions via
WARP_CLI_AGENT_PROTOCOL_VERSIONand prefer OSC 9 when notification method isauto. - Bypass Codex’s focus-based notification suppression when running under Warp.
- Add a unit test covering auto-selection of OSC 9 for Warp-detected sessions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
codex-rs/tui/src/tui.rs |
Adjusts notify() gating so Warp sessions are not suppressed by terminal_focused. |
codex-rs/tui/src/notifications/mod.rs |
Adds Warp env-var detection, plugs it into OSC 9 capability detection, and expands tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARP_CLI_AGENT_PROTOCOL_VERSIONand select the OSC 9 notification backend when notification method isauto.codex-rs/tuilayout without reintroducing the removedtui_app_servertree.Context
Warp supports OSC 9 notifications and exposes its CLI agent protocol environment variable in supported sessions. Codex already used OSC 9 for terminals like WezTerm/Ghostty; this extends that path to Warp and avoids suppressing Warp notifications based on focus state.
Testing
just fmtcargo test -p codex-tuijust argument-comment-lintgit diff --check