Add marketplace command by xli-oai · Pull Request #17087 · openai/codex

xli-oai · 2026-04-08T05:46:57Z

Added a new top-level codex marketplace add command for installing plugin marketplaces into Codex’s local marketplace cache.

This change adds source parsing for local directories, GitHub shorthand, and git URLs, supports optional --ref and git-only --sparse checkout paths, stages the source in a temp directory, validates the marketplace manifest, and installs it under $CODEX_HOME/marketplaces/<marketplace-name>

Included tests cover local install behavior in the CLI and marketplace discovery from installed roots in core. Scoped formatting and fix passes were run, and targeted CLI/core tests passed.

github-actions · 2026-04-08T05:47:09Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

xli-oai · 2026-04-08T05:50:02Z

I have read the CLA Document and I hereby sign the CLA

codex-rs/core/src/plugins/manager.rs

codex-rs/cli/src/marketplace_cmd.rs

codex-rs/core/src/plugins/manager.rs

xli-oai · 2026-04-08T21:22:14Z

Design / storage summary for this PR:

Filesystem layout

$CODEX_HOME/.tmp/plugins/ remains the existing OpenAI-curated marketplace checkout. This PR does not move or rename it.
$CODEX_HOME/.tmp/marketplaces/<marketplace-name>/ is where marketplaces added by codex marketplace add are materialized.
$CODEX_HOME/.tmp/marketplaces/.staging/ is temporary staging space used while cloning/copying before install.
$CODEX_HOME/.tmp/known_marketplaces.json records the user-added marketplace roots that discovery should include.
$CODEX_HOME/plugins/cache/<marketplace>/<plugin>/<version>/ remains the existing plugin artifact/install cache. Marketplace add does not install plugin artifacts into this cache.

Flow

codex marketplace add <source> accepts a local marketplace directory or a git-like source. It stages the source first, by copying a local directory or cloning a git repo, validates the staged root as a Codex marketplace, rejects the reserved openai-curated marketplace name, then atomically replaces the add-managed destination for that marketplace name and records it in the local known-marketplaces registry.

After that, normal marketplace discovery combines the registered user-added marketplace roots with the existing curated checkout. Plugin listing can see plugins from the newly added marketplace, but already-installed plugin artifacts are left untouched.

xl-openai · 2026-04-08T23:28:18Z

codex-rs/core/src/plugins/manager.rs

    }
 }

+pub fn marketplace_install_root(codex_home: &Path) -> PathBuf {


maybe have a marketplace.rs or something as this file becomes too big.

xl-openai · 2026-04-08T23:32:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9b23d58b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T23:35:05Z

codex-rs/core/src/plugins/manager.rs

+    if registry_path.is_file() {
+        return installed_marketplace_roots_from_registry(&registry_path);


Fall back to disk scan when registry parsing fails

installed_marketplace_roots immediately trusts known_marketplaces.json when it exists. If that file is malformed/truncated, installed_marketplace_roots_from_registry returns an empty list and no filesystem fallback runs, so valid marketplaces under .tmp/marketplaces vanish from discovery. A single bad registry file effectively disables all installed marketplaces.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-08T23:35:05Z

codex-rs/cli/src/marketplace_cmd.rs

+    let backup = if destination.exists() {
+        let parent = destination
+            .parent()
+            .context("marketplace destination has no parent")?;
+        let staging_root = marketplace_staging_root(parent);
+        fs::create_dir_all(&staging_root)?;
+        let backup = tempfile::Builder::new()
+            .prefix("marketplace-backup-")
+            .tempdir_in(&staging_root)?;
+        let backup_root = backup.path().join("previous");
+        fs::rename(destination, &backup_root)?;
+        Some((backup, backup_root))


Prevent concurrent add from overwriting existing marketplace

run_add rejects existing destinations, but replace_marketplace_root still replaces any destination that appears later. If another marketplace add creates the same directory between the check and this rename, this process moves the existing install aside and overwrites it. That TOCTOU race causes lost updates instead of the expected conflict error.

Useful? React with 👍 / 👎.

sayan-oai · 2026-04-09T03:53:43Z

codex-rs/core/src/plugins/manager.rs

+fn marketplace_registry_path(codex_home: &Path) -> PathBuf {
+    codex_home.join(".tmp").join(KNOWN_MARKETPLACES_FILE)
+}


why do we need known_marketplaces.json? if marketplaces added via this CLI command are installed to a static location, can't we just walk that dir to find installed marketplaces?

chatted offline, its to track metadata about plugin source.

sayan-oai · 2026-04-09T03:58:32Z

codex-rs/cli/src/marketplace_cmd.rs

+    /// Sparse-checkout paths to use while cloning git sources.
+    #[arg(long = "sparse", value_name = "PATH", num_args = 1..)]
+    sparse_paths: Vec<String>,
+}


i dont think this works (--sparse swallows source):
codex marketplace add --sparse plugins/foo owner/repo

what about something like:
codex marketplace add owner/repo --sparse plugins/foo?

yes, nice catch!

sayan-oai · 2026-04-09T04:03:03Z

codex-rs/cli/src/marketplace_cmd.rs

+    let marketplace_name = validate_marketplace_root(&staged_root)
+        .with_context(|| format!("failed to validate marketplace from {}", source.display()))?;


i think plugins require marketplace names to be only ASCII alnum / _ / -, should we enforce that here as well?

xli-oai · 2026-04-09T04:57:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 972d3a5495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T05:02:42Z

codex-rs/cli/src/marketplace_cmd.rs

+            source.display()
+        );
+        println!("Installed marketplace root: {}", existing_root.display());
+        return Ok(());


Re-record registry on idempotent source adds

When marketplace add finds an already-installed source, it returns immediately without calling record_installed_marketplace_root. If known_marketplaces.json exists but is missing that entry, discovery trusts the registry and skips disk scan, so the marketplace stays invisible even though the CLI reports it is already added.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-09T05:02:42Z

codex-rs/cli/src/marketplace_cmd/metadata.rs

+        if !metadata_path.is_file() {
+            continue;
+        }
+        let metadata = read_marketplace_source_metadata(&root)?;


Skip bad metadata entries while scanning installs

A single malformed .codex-marketplace-source file aborts installed_marketplace_root_for_source because parse errors are propagated. That prevents adding unrelated marketplaces whenever one existing install has corrupted metadata, turning one bad entry into a global failure.

Useful? React with 👍 / 👎.

sayan-oai

thanks for cleaning up! one nit

sayan-oai · 2026-04-09T05:49:39Z

codex-rs/cli/src/marketplace_cmd.rs

+    source.starts_with("git@") && source.contains(':')
+}
+
+fn is_http_git_url(source: &str) -> bool {


nit-ish: feels like theres a lot of local FS operations/git operations alongside the main CLI command parsing.

maybe worth breaking up those ops into another file, or moving stuff to plugins module?

will leave it up to you

github-actions bot added a commit that referenced this pull request Apr 8, 2026

@xli-oai has signed the CLA in #17087

d204192

xl-openai reviewed Apr 8, 2026

View reviewed changes

codex-rs/core/src/plugins/manager.rs Show resolved Hide resolved

xl-openai reviewed Apr 8, 2026

View reviewed changes

codex-rs/cli/src/marketplace_cmd.rs Show resolved Hide resolved

xl-openai reviewed Apr 8, 2026

View reviewed changes

codex-rs/core/src/plugins/manager.rs Show resolved Hide resolved

xli-oai marked this pull request as ready for review April 8, 2026 21:32

xli-oai force-pushed the xli-codex/marketplace-add-command branch 6 times, most recently from faaff79 to f4909a7 Compare April 8, 2026 23:24

xl-openai reviewed Apr 8, 2026

View reviewed changes

Add marketplace add command support

f9b23d5

xli-oai force-pushed the xli-codex/marketplace-add-command branch from f4909a7 to f9b23d5 Compare April 8, 2026 23:32

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

github-actions bot mentioned this pull request Apr 9, 2026

📊 AI CLI 工具社区动态日报 2026-04-09 gsscsd/big_model_radar#157

Open

xli-oai requested a review from sayan-oai April 9, 2026 03:03

sayan-oai reviewed Apr 9, 2026

View reviewed changes

xli-oai added 4 commits April 8, 2026 21:41

Address marketplace add review feedback

adbc32b

Fix marketplace add sparse argument parsing

23f845b

Test marketplace add sparse CLI parsing

bd32fb4

Reject invalid marketplace names on add

972d3a5

chatgpt-codex-connector bot reviewed Apr 9, 2026

View reviewed changes

xl-openai approved these changes Apr 9, 2026

View reviewed changes

sayan-oai approved these changes Apr 9, 2026

View reviewed changes

xli-oai force-pushed the xli-codex/marketplace-add-command branch from e8fa02e to 972d3a5 Compare April 9, 2026 22:14

		if registry_path.is_file() {
		return installed_marketplace_roots_from_registry(&registry_path);

		let marketplace_name = validate_marketplace_root(&staged_root)
		.with_context(\|\| format!("failed to validate marketplace from {}", source.display()))?;

Conversation

xli-oai commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xli-oai commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xli-oai commented Apr 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xl-openai commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xli-oai commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

sayan-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xli-oai commented Apr 8, 2026 •

edited

Loading

github-actions bot commented Apr 8, 2026 •

edited

Loading