Skip to content

[codex-analytics] enable general analytics by default#17389

Merged
rhan-oai merged 2 commits intomainfrom
rhan/general-analytics
Apr 14, 2026
Merged

[codex-analytics] enable general analytics by default#17389
rhan-oai merged 2 commits intomainfrom
rhan/general-analytics

Conversation

@rhan-oai
Copy link
Copy Markdown
Collaborator

Summary

  • Make GeneralAnalytics stable and enabled by default.
  • Update feature tests and app-server lifecycle fixtures for explicit general_analytics=false.
  • Keep app-server integration tests isolated from host managed config so explicit feature fixtures are deterministic.

Validation

  • cargo test -p codex-features
  • cargo test -p codex-app-server general_analytics (matched 0 tests)
  • cargo test -p codex-app-server thread_start_
  • cargo test -p codex-app-server thread_fork_
  • cargo test -p codex-app-server thread_resume_
  • cargo test -p codex-app-server config_read_includes_system_layer_and_overrides

Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preapproving

# Conflicts:
#	codex-rs/app-server/src/main.rs
#	codex-rs/app-server/tests/suite/v2/thread_start.rs
@rhan-oai rhan-oai marked this pull request as ready for review April 14, 2026 16:17
@rhan-oai rhan-oai merged commit d6b1327 into main Apr 14, 2026
27 of 30 checks passed
@rhan-oai rhan-oai deleted the rhan/general-analytics branch April 14, 2026 20:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants