Skip to content

Stabilize marketplace add local source test#17424

Merged
ningyi-oai merged 1 commit intomainfrom
dev/ningyi/marketplace-windows-local-path
Apr 11, 2026
Merged

Stabilize marketplace add local source test#17424
ningyi-oai merged 1 commit intomainfrom
dev/ningyi/marketplace-windows-local-path

Conversation

@ningyi-oai
Copy link
Copy Markdown
Contributor

@ningyi-oai ningyi-oai commented Apr 11, 2026

Summary

  • Update the marketplace add local-source integration test to pass an explicit relative local path. Fix a failing test marketplace_add_rejects_local_directory_source
  • Keep the change test-only; no CLI source parsing behavior changes.

Tests

  • cargo fmt -p codex-cli
  • cargo test -p codex-cli --test marketplace_add

Impact

  • Production behavior is unchanged.
  • No impact to feedback upload logic, DAGs, exports, or downstream pipelines.

@ningyi-oai ningyi-oai force-pushed the dev/ningyi/marketplace-windows-local-path branch from 59307dc to 04f5cd1 Compare April 11, 2026 04:26
@ningyi-oai ningyi-oai changed the title Fix marketplace add Windows local path detection Stabilize marketplace add local source test Apr 11, 2026
@ningyi-oai ningyi-oai marked this pull request as ready for review April 11, 2026 04:27
Use an explicit relative local marketplace source in the integration test so it exercises the local-source rejection path consistently across platforms.

Co-authored-by: Codex <noreply@openai.com>
@ningyi-oai ningyi-oai force-pushed the dev/ningyi/marketplace-windows-local-path branch from 04f5cd1 to 479bff4 Compare April 11, 2026 04:31
@ningyi-oai ningyi-oai enabled auto-merge (squash) April 11, 2026 04:38
@ningyi-oai ningyi-oai merged commit a9796e3 into main Apr 11, 2026
42 of 46 checks passed
@ningyi-oai ningyi-oai deleted the dev/ningyi/marketplace-windows-local-path branch April 11, 2026 05:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants