Merged
Conversation
Pin Rust git patches to immutable revisions, verify V8 override assets with checked-in checksums, require explicit cargo-deny git sources, and pin release/tooling actions and cargo installs. Co-authored-by: Codex noreply@openai.com
Add update and check commands for keeping MODULE.bazel rusty_v8 http_file hashes in sync with the checked-in checksum manifest, then run the check in Bazel CI. Co-authored-by: Codex noreply@openai.com
Pin the remaining tag-based action refs in Bazel CI and setup-bazel-ci. Normalize setup-bazelisk v3 pins to the peeled commit behind the annotated tag. Co-authored-by: Codex noreply@openai.com
bolinfest
approved these changes
Apr 14, 2026
Collaborator
bolinfest
left a comment
There was a problem hiding this comment.
Mostly small comments except for the shared action bit.
Extract the duplicated musl rusty_v8 override and checksum verification logic into a local composite action, then use it from release and full CI workflows. Co-authored-by: Codex noreply@openai.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Future V8 bump flow
Run these after updating the resolved
v8crate version and checksum manifest:The update command rewrites the matching
rusty_v8_<crate_version>http_fileSHA-256 values inMODULE.bazelfromthird_party/v8/rusty_v8_<crate_version>.sha256. The check command is also wired into Bazel CI to block drift.Notes
Validation
uses:audit: all external action refs are pinned to 40-character SHAsHash verification
MODULE.bazelhashes matchthird_party/v8/rusty_v8_146_4_0.sha256.v146.4.0and openai/codexrusty-v8-v146.4.0match the checked-in hashes.MODULE.bazelrusty_v8 asset URLs locally; every downloaded byte stream matched bothMODULE.bazeland the checked-in manifest.Pin verification
sigstore/cosign-installer@v3.7.0,azure/login@v2, andazure/trusted-signing-action@v0.actions/setup-node@v6,facebook/install-dotslash@v2,bazelbuild/setup-bazelisk@v3, andactions/cache/restore@v5.bazelbuild/setup-bazelisk@v3refs to the peeled commit behind the annotated tag.revonly, everyCargo.lockgit source has?rev=<sha>#<same-sha>, andcargo deny check sourcespasses withrequired-git-spec = "rev".