changing decision semantics after guardian timeout#17486
Merged
won-openai merged 3 commits intomainfrom Apr 12, 2026
Merged
Conversation
won-openai
commented
Apr 11, 2026
|
|
||
| const GUARDIAN_TIMEOUT_INSTRUCTIONS: &str = concat!( | ||
| "The automatic approval review did not finish before its deadline. ", | ||
| "Do not assume the action is unsafe based on the timeout alone. ", |
Collaborator
Author
There was a problem hiding this comment.
thoughts on what the instruction shuold be?
dylan-hurd-oai
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR treats Guardian timeouts as distinct from explicit denials in the core approval paths.
Timeouts now return timeout-specific guidance instead of Guardian policy-rejection messaging.
It updates the command, shell, network, and MCP approval flows and adds focused test coverage.