Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9438f6891
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if sess.conversation.running_state().await.is_none() { | ||
| return; | ||
| } | ||
| if let Err(err) = sess.conversation.text_in(text).await { |
There was a problem hiding this comment.
mirror_user_text_to_realtime now sends every accepted typed turn into realtime via conversation.text_in (codex.rs), but realtime fanout still routes every HandoffRequested back through route_realtime_text_input (realtime_conversation.rs). In V2, text_in requests a response (handle_user_text_input), so mirrored text can be re-injected as a second user steer, duplicating input and altering turn behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0b675291d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03606c72fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .await; | ||
| return Err(mapped_error.into()); | ||
| } | ||
| match session_kind { | ||
| RealtimeSessionKind::V1 => {} | ||
| RealtimeSessionKind::V2 => { | ||
| response_create_queue | ||
| .request_create(writer, events_tx, "text") | ||
| .await?; | ||
| } | ||
| } | ||
| Ok(()) |
There was a problem hiding this comment.
handle_user_text_input now only sends conversation.item.create and returns. Realtime V2 requires a follow-up response.create (queued when a response is active) for text turns to produce output; app-server thread/realtime/appendText flows depend on that behavior. As written, text is mirrored into the session but no realtime response is started.
Useful? React with 👍 / 👎.
aibrahim-oai
changed the title
aibrahim-oai
changed the title
1 participant
Uh oh!
There was an error while loading. Please reload this page.