[codex] Add guardian context to PermissionRequest hooks#17564
Closed
abhinav-oai wants to merge 1 commit intocodex/permission-request-hooks-basefrom
Closed
[codex] Add guardian context to PermissionRequest hooks#17564abhinav-oai wants to merge 1 commit intocodex/permission-request-hooks-basefrom
abhinav-oai wants to merge 1 commit intocodex/permission-request-hooks-basefrom
Conversation
Run guardian before Bash PermissionRequest hooks when approvals are already routed to guardian, pass the review into the hook input as advisory context, and reuse the guardian decision when hooks stay quiet. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on #17563 and adds the guardian-specific PermissionRequest behavior.
When an approval would route through guardian, Codex now runs guardian first, passes the resulting review into the PermissionRequest hook input as advisory context, and reuses that guardian decision if matching hooks stay quiet. Hooks can still explicitly allow or deny the approval prompt.
Validation
just write-hooks-schemajust fmtcargo test -p codex-hookscargo test -p codex-core permission_request_hookjust fix -p codex-corejust fix -p codex-hooks