fix: protect active arg0 helper dirs#17570
Open
viyatb-oai wants to merge 4 commits into
Open
Conversation
Co-authored-by: Codex noreply@openai.com
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps live arg0 helper directories from being removed during startup cleanup. Each new helper dir now writes a
.pidowner sentinel, and the janitor skips directories whose owner process is still running before falling back to the existing lock-based stale cleanup.Issues Fixed
~/.codex/tmp/arg0/codex-arg0*/codex-linux-sandboxhelper path and failing non-escalated unified exec /apply_patchcalls with ENOENT until app restart.Root Cause
Codex Desktop sessions can cache helper paths such as
~/.codex/tmp/arg0/codex-arg0*/codex-linux-sandbox. The arg0 janitor previously trusted the helper directory lock as the only signal that another process still owned the directory. On WSL-backed workspaces withCODEX_HOMEon the Windows-mounted home, those advisory locks can be unreliable, so a later startup could remove another live session's helper directory. Non-escalated unified exec andapply_patchthen fail with ENOENT until the app restarts.