Route apply_patch through the environment filesystem by starr-openai · Pull Request #17674 · openai/codex

starr-openai · 2026-04-13T19:04:50Z

Summary

route apply_patch runtime execution through the selected Environment filesystem instead of the local self-exec path
keep the standalone apply_patch command surface intact while restoring its launcher/test/docs contract
add focused apply_patch filesystem sandbox regression coverage

Validation

remote devbox Bazel run in progress
passed: //codex-rs/apply-patch:apply-patch-unit-tests --test_filter=test_read_file_utf8_with_context_reports_invalid_utf8
in progress / follow-up: focused core and exec Bazel test slices on dev

Follow-up under review

remote pre-verification and approval/retry behavior still need explicit scrutiny for delete/update flows
runtime sandbox-denial classification may need a tighter assertion path than rendered stderr matching

Co-authored-by: Codex <noreply@openai.com>

Only create parent directories when the parent is actually missing so file-level approvals do not trip on existing parent directories. Co-authored-by: Codex <noreply@openai.com>

Attempt the write before creating parent directories so file-scoped approvals do not require a separate parent-directory metadata probe. Co-authored-by: Codex <noreply@openai.com>

starr-openai added a commit that referenced this pull request Apr 13, 2026

codex: remove dead apply_patch timeout plumbing (#17674)

d622b99

Co-authored-by: Codex <noreply@openai.com>

starr-openai added a commit that referenced this pull request Apr 13, 2026

codex: satisfy clippy in apply_patch fs sandbox tests (#17674)

97ab96e

Co-authored-by: Codex <noreply@openai.com>

pakrym-oai reviewed Apr 13, 2026

View reviewed changes

Comment thread codex-rs/apply-patch/tests/fs_sandbox.rs Outdated

pakrym-oai reviewed Apr 13, 2026

View reviewed changes

Comment thread codex-rs/arg0/src/lib.rs Outdated

starr-openai added a commit that referenced this pull request Apr 13, 2026

codex: avoid redundant apply_patch mkdir under env fs (#17674)

b523b39

Co-authored-by: Codex <noreply@openai.com>

starr-openai added a commit that referenced this pull request Apr 13, 2026

codex: replace fake fs apply_patch tests (#17674)

6fd8e5d

Co-authored-by: Codex <noreply@openai.com>

starr-openai added a commit that referenced this pull request Apr 13, 2026

codex: align exec-server missing-parent test style (#17674)

3b740d4

Co-authored-by: Codex <noreply@openai.com>

starr-openai marked this pull request as ready for review April 13, 2026 21:42

starr-openai mentioned this pull request Apr 13, 2026

Make discoverable plugin warning-path test cross-platform #17723

Closed

starr-openai and others added 8 commits April 13, 2026 16:55

Route apply_patch through the environment filesystem

3778fe2

Co-authored-by: Codex <noreply@openai.com>

codex: remove dead apply_patch timeout plumbing (#17674)

de463bf

Co-authored-by: Codex <noreply@openai.com>

codex: satisfy clippy in apply_patch fs sandbox tests (#17674)

665eb44

Co-authored-by: Codex <noreply@openai.com>

codex: avoid redundant apply_patch mkdir under env fs (#17674)

dfb51f5

Co-authored-by: Codex <noreply@openai.com>

codex: replace fake fs apply_patch tests (#17674)

2b9520f

Co-authored-by: Codex <noreply@openai.com>

codex: align exec-server missing-parent test style (#17674)

ea20b6c

Co-authored-by: Codex <noreply@openai.com>

Remove arg0 apply_patch env test

0b99cdc

Co-authored-by: Codex <noreply@openai.com>

Restore apply_patch output delta events

d595a3f

Co-authored-by: Codex <noreply@openai.com>

starr-openai force-pushed the starr/apply-patch-envfs-agent3-20260413 branch from a0fbf33 to d595a3f Compare April 13, 2026 23:55