Conversation
euroelessar
approved these changes
Apr 13, 2026
jif-oai
approved these changes
Apr 13, 2026
Contributor
Author
|
just to follow up, it seems like main CI SHOULD have failed with this error, but it currently doesn't for some reason. PR CI indeed does not set the flags in such a way that would catch this kind of error |
Collaborator
|
I believe that this code is only reachable behind: and the Bazel builds in CI only build in debug mode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent release broke, codex suggested this as the fix
Source failure: https://github.com/openai/codex/actions/runs/24362949066/job/71147202092
Probably from ac82443
For why it got in:
Codex tested locally with
cargo check -p codex-tui --releaseand was able to repro, and verified that this fixed it