Skip to content

Fix tui compilation#17691

Merged
jif-oai merged 1 commit intomainfrom
dev/david.hao/fix-compilation
Apr 13, 2026
Merged

Fix tui compilation#17691
jif-oai merged 1 commit intomainfrom
dev/david.hao/fix-compilation

Conversation

@davidhao3300
Copy link
Copy Markdown
Contributor

@davidhao3300 davidhao3300 commented Apr 13, 2026

The recent release broke, codex suggested this as the fix

Source failure: https://github.com/openai/codex/actions/runs/24362949066/job/71147202092

Probably from ac82443

For why it got in:

The relevant setup:

.github/workflows/rust-ci.yml (line 1) runs on PRs, but for codex-rs it only does:

cargo fmt --check
cargo shear
argument-comment lint via Bazel
no cargo check, no cargo clippy over the workspace, no cargo test over codex-tui
.github/workflows/rust-ci-full.yml (line 1) runs on pushes to main and branches matching **full-ci**. That one does compile TUI because:

codex-rs/Cargo.toml includes "tui" as a workspace member
lint_build runs cargo clippy --target ... --tests --profile ...
the matrix includes both dev and release profiles
tests runs cargo nextest run ..., but only dev-profile tests
Release CI also compiles it indirectly. .github/workflows/rust-release.yml (line 235) builds --bin codex, and cli/Cargo.toml (line 46) depends on codex-tui.

Codex tested locally with cargo check -p codex-tui --release and was able to repro, and verified that this fixed it

@davidhao3300 davidhao3300 marked this pull request as ready for review April 13, 2026 20:35
@davidhao3300 davidhao3300 requested a review from pakrym-oai April 13, 2026 20:36
@jif-oai jif-oai merged commit 7c43f8b into main Apr 13, 2026
21 of 22 checks passed
@jif-oai jif-oai deleted the dev/david.hao/fix-compilation branch April 13, 2026 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2026
@davidhao3300
Copy link
Copy Markdown
Contributor Author

just to follow up, it seems like main CI SHOULD have failed with this error, but it currently doesn't for some reason. PR CI indeed does not set the flags in such a way that would catch this kind of error

@bolinfest
Copy link
Copy Markdown
Collaborator

I believe that this code is only reachable behind:

#[cfg(not(debug_assertions))]

and the Bazel builds in CI only build in debug mode?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants